-
Notifications
You must be signed in to change notification settings - Fork 41k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for auto-configuring SimpleMessageListenerContainer #44465
base: main
Are you sure you want to change the base?
Conversation
Thanks for the suggestion but we don't really consider a promotion of What's your use of |
Semantics of
My specific use case is that I'm using SQS and Amazon SQS Java Messaging Library provided by AWS. This JMS implementation doesn't support transactions, but provides custom acknowledge mode that better fits SQS, and internally has its own prefetching/polling mechanism that aligns usage of SQS API with JMS spec. From my experience I'd like to avoid copying boilerplate configuration from project to project and use configuration property based approach to opt into using |
443576d
to
5ced34f
Compare
This commit introduces a new `spring.jms.listener.container-type` configuration property which can be used to auto-configure JMS listener support backend by `SimpleMessageListenerContainer` instead of `DefaultMessageListenerContainer`. Signed-off-by: Vedran Pavic <[email protected]>
5ced34f
to
c71222e
Compare
@Override | ||
public void setObservationRegistry(ObservationRegistry observationRegistry) { | ||
this.observationRegistry = observationRegistry; | ||
super.setObservationRegistry(observationRegistry); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This override is here to preserve backwards compatibility (see #44466), as AbstractJmsListenerContainerFactoryConfigurer
introduced in this PR reduces visibility to package private.
This commit introduces a new
spring.jms.listener.container-type
configuration property which can be used to auto-configure JMS listener support backend bySimpleMessageListenerContainer
instead ofDefaultMessageListenerContainer
.